Implement complex TSMT inert for depth 16->32 case #1036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Al-Kindi-0
approved these changes
Aug 10, 2023
There was a problem hiding this comment.
Looks great, @bobbinth ! The procedure turned out to be quiet involved but the inlined docs greatly help to lessen the complexity of the code. I personally don't see any immediate simplifications or optimizations.
bobbinth
force-pushed
the
bobbin-smt-insert
branch
from
6a5e2f9
to
5b3b93b
Compare
bobbinth
force-pushed
the
bobbin-tsmt-replace
branch
from
29add25
to
2f16376
Compare
bobbinth
force-pushed
the
bobbin-tsmt-replace
branch
from
2f16376
to
4f1dc0e
Compare
This was referenced Aug 29, 2023
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements an insert procedure in std::collections::smt to handle the case when an inserted key-value pair collides with an existing leaf at depth 16 and both key-value pairs must be moved to leaves at depth 32.