-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Expand capabilities of the debug
instruction
#1103
Conversation
c78ca65
to
e13205f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! Looks good! This is not a full review yet, but I wanted to leave a few comments and I think it will change things a bit.
Also, could you paste a couple of screen shots of how the results look like?
e580c9e
to
ab600ee
Compare
There is a problem with formatting the final print of the memory address and value (as you mentioned it here). I didn't find the way to parametrize the output: in case we print in decimal we need to have something like Without that parametrization the code which outputs the values would be almost identical except the parts mentioned above, so there will be a lot of copy-paste. For now I left only the decimal form for both global and local memory. I am not sure how these addresses would be used in debugging, so I don't now how crucial or convenient will be using hexes instead of decimals. Now output looks like that: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you! I left some more comments inline. Regarding formatting, I suggested how we can format addresses/indexes for mem vs. locals. Let me know if that doesn't work for some reason.
e872242
to
51b3f39
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I left a few more comments inline.
I think it looks good! Let's keep it as you have it. |
bb1264f
to
2f1bf3c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I left a few nit comments inline. After these are addressed, we can merge.
2f1bf3c
to
a672a52
Compare
This PR expands the capabilities of the
debug
instruction by printing information about memory and procedure locals, namely:debug.mem
prints out the entire contents of RAM.debug.mem.<n>
prints out contents of memory at addressn
.debug.mem.<n>.<m>
prints out the contents of memory starting at addressn
and ending at addressm
(both inclusive).m
must be greater thann
.debug.local
prints out all locals of the currently executing procedure.debug.local.<n>
prints out contents of the local at indexn
for the currently executing procedure.debug.local.<n>.<m>
prints out contents of the local starting at indexn
and ending at indexm
(both inclusive).m
must be greater thann
.TODO: