Memory: Create newtype ContextId
#1117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Oct 23, 2023
There was a problem hiding this comment.
Thank you! Totally agree with the motivation of the PR (and also think it would be a good idea to have a special type for memory address - though, probably in a different PR). A few preliminary comments:
- I think a single
ContextIdtype will probably suffice. Specifically, I don't think we need another type forMemoryContextId. I would also put the definition ofContextIdinto/src/system/mod.rsrather than into memory chiplet. - I don't think we need to implement arithmetic operations on
ContextId. As far as I remember, we never actually add/subtract contexts. - We usually try to reduce the number of non-dev dependencies as much as possible. So, I would probably manually implement
Display,Intoetc. traits onContextIdrather than adding an extra dependency.
The only arithmetic we do is a subtraction here. For now I'll implement only I applied all the other requested changes! |
bobbinth
approved these changes
Oct 23, 2023
bobbinth
approved these changes
Oct 24, 2023
Al-Kindi-0
pushed a commit
that referenced
this pull request
Dec 5, 2023
* ContextId type * propagate MemoryContextId * fix tests * MemoryContextId -> ContextId * move definition * Remove derive-more dependency * fix repl * fmt * docstring * import newline * Remove `Sub` from `ContextId` * blank line * section name change * blank line * use `ContextId::root()` * fmt * memory context -> execution context
bobbinth
pushed a commit
that referenced
this pull request
Feb 26, 2024
* ContextId type * propagate MemoryContextId * fix tests * MemoryContextId -> ContextId * move definition * Remove derive-more dependency * fix repl * fmt * docstring * import newline * Remove `Sub` from `ContextId` * blank line * section name change * blank line * use `ContextId::root()` * fmt * memory context -> execution context
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Creates the
ContextIdtype instead of usingu32everywhere. This makes the code easier to understand to a newcomer; e.g. types such as(u32, u32, u32)make understanding the code harder. And this newtype will also prevent bugs which e.g. use the context ID as an address (who's also au32).I suggest we also introduce a newtype for memory
Address.