Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support constants in MASM repeat loops #1124

Merged
merged 3 commits into from
Oct 30, 2023
Merged

Support constants in MASM repeat loops #1124

merged 3 commits into from
Oct 30, 2023

Conversation

Fumuran
Copy link
Contributor

@Fumuran Fumuran commented Oct 28, 2023

This small PR adds support for constants used as counters in repeat loops.
For example:

const.A=3

begin 
    repeat.A
        push.1
    end
end

@Fumuran Fumuran requested a review from bobbinth October 28, 2023 08:11
@Fumuran Fumuran linked an issue Oct 28, 2023 that may be closed by this pull request
Add support for constants on MASM control flow #970
Closed
bobbinth
bobbinth requested changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! Looks good! I left a couple of small comments inline.

assembly/src/ast/tests.rs Show resolved Hide resolved
assembly/src/tokens/mod.rs Outdated Show resolved Hide resolved
@Fumuran Fumuran requested a review from bobbinth October 30, 2023 20:24
bobbinth
bobbinth approved these changes Oct 30, 2023
View reviewed changes
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you! I left one small comment inline. Also, let's update CHANGELOG. After these, we can merge.

docs/src/user_docs/assembly/flow_control.md Outdated Show resolved Hide resolved
@bobbinth bobbinth merged commit d76da5d into next Oct 30, 2023
15 checks passed
@bobbinth bobbinth deleted the andrew-support-constants-on-control-flow branch October 30, 2023 22:50
@bobbinth bobbinth mentioned this pull request Oct 30, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bobbinth bobbinth bobbinth approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support for constants on MASM control flow
2 participants
@Fumuran @bobbinth