mpverify: don't panic when verification fails
#1230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bobbinth
reviewed
Feb 1, 2024
Comment on lines
89
to
90
| assert_eq!(root, computed_root, "inconsistent Merkle tree root"); | ||
| if root == computed_root { |
There was a problem hiding this comment.
We should probably remove assert_eq from here and the the condition for the if statement should be root != computed_root - right?
There was a problem hiding this comment.
Also, the comment should be updated.
There was a problem hiding this comment.
Oops - and it should have been !=. Fixed
bobbinth
pushed a commit
that referenced
this pull request
Feb 26, 2024
* Replace `panic!()` with `Err()` * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Converts a
panic!()into an error when Merkle Path verification fails.