-
Notifications
You must be signed in to change notification settings - Fork 160
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prepare for migration to next release of Miden crypto #1287
Conversation
|
Updated the PR accordingly. There is a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Rebasing my PR on this shouldn't be too bad, probably not worth trying to introduce any additional formatting changes here though, or it will make conflicts harder to untangle. I did a quick review of the commits in my PR, and I don't have a specific commit where I introduced formatting changes explicitly, so I think any such changes fell out of modifying a file for other reasons, and the formatter changing the file in the process. Of course, with the number of files touched, that means there is a fair amount of formatting noise in that PR.
Once this is merged, I'll rebase my PR on it and that should make future rebases less problematic.
I would add a |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! Thank you! I pushed a small commit which fixes the clippy warning. In the longer run, we should remove this field as I don't think we need it any more (I believe it was used for auxiliary trace hints, but these are now done differently).
One thing I wonder about: maybe we should handle signature generation code via events and have the decorator only for reading the signature from the advice provider. I'll try to write up an issue about this.
* chore: fix no-std errors * fix: Falcon DSA decorators and tests
Describe your changes
Mostly
no-std
issues and Falcon DSA.Checklist before requesting a review
next
according to naming convention.