Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add changelog.yml file #1406

Merged
merged 8 commits into from
Jul 18, 2024
Merged

Add changelog.yml file #1406

merged 8 commits into from
Jul 18, 2024

Conversation

phklive
Copy link
Contributor

@phklive phklive commented Jul 18, 2024

In this PR I add a changelog.yml file.

This should solve this issue of failing changelog CI job on push to next or main.

My rationale is that the CHANGELOG.md file is considered modified when the PR is still opened but on merge this job should not be ran because the PR context does not exist anymore.

It also adds logic to support the no changelog label that can be put on a PR that does not require an update in the CHANGELOG.md file.

Once this PR is merged and we confirmed it's functionality I will port these changes to the:

  • Node
  • Base

And then follow your recommendations regarding other repositories.

@phklive phklive added the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Jul 18, 2024
@phklive phklive removed the no changelog This PR does not require an entry in the `CHANGELOG.md` file label Jul 18, 2024
@phklive phklive marked this pull request as ready for review July 18, 2024 12:55
@phklive phklive requested a review from bobbinth July 18, 2024 12:55
Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you!

@bobbinth bobbinth merged commit 323160d into next Jul 18, 2024
9 checks passed
@bobbinth bobbinth deleted the phklive-update-changelog-workflow branch July 18, 2024 17:53
@phklive
Copy link
Contributor Author

phklive commented Jul 22, 2024

This PR on the changelog seems to have had the correct effects, hence I am porting it to node and base for now:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants