Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix block stack table #1511

Merged
merged 1 commit into from
Sep 25, 2024
Merged

Fix block stack table #1511

merged 1 commit into from
Sep 25, 2024

Conversation

plafer
Copy link
Contributor

@plafer plafer commented Sep 25, 2024

Fixes the block stack table with the following logic:

  • on CALL: fn_hash contains the parent function hash; it is only set to callee_hash in the next row
  • on SYSCALL: fn_hash also contains the parent function hash; it remains unchanged by a syscall
  • on END for call/syscall: block stack logic resets the fn_hash columns to the parent fn hash only in the next row

@plafer plafer marked this pull request as draft September 25, 2024 11:57
@plafer plafer marked this pull request as ready for review September 25, 2024 18:04
@plafer
Copy link
Contributor Author

plafer commented Sep 25, 2024

Related: #483 for docs

Copy link
Contributor

@bobbinth bobbinth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Thank you for fixing this!

@bobbinth bobbinth merged commit 7ee5170 into next Sep 25, 2024
9 checks passed
@bobbinth bobbinth deleted the plafer-fix-block-stack-table branch September 25, 2024 18:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants