Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Modexp memory context change #1102

Merged
merged 10 commits into from
Jun 21, 2023
Merged

Conversation

npwardberkeley
Copy link
Contributor

No description provided.

Copy link
Contributor

@wborgeaud wborgeaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also need to update evm/src/cpu/kernel/asm/core/precompiles/expmod.asm, but otherwise looks good.

evm/src/cpu/kernel/asm/bignum/util.asm Outdated Show resolved Hide resolved
evm/src/cpu/kernel/asm/bignum/util.asm Outdated Show resolved Hide resolved
evm/Cargo.toml Outdated Show resolved Hide resolved
Copy link
Contributor

@wborgeaud wborgeaud left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

@npwardberkeley npwardberkeley merged commit 3de92d9 into main Jun 21, 2023
@npwardberkeley npwardberkeley deleted the modexp-memory-context-change branch June 21, 2023 22:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants