Skip to content
This repository has been archived by the owner on Jun 20, 2024. It is now read-only.

Provide txn IR for debugging upon failure #11

Closed
Nashtare opened this issue Dec 7, 2023 · 3 comments · Fixed by #48
Closed

Provide txn IR for debugging upon failure #11

Nashtare opened this issue Dec 7, 2023 · 3 comments · Fixed by #48
Assignees

Comments

@Nashtare
Copy link
Collaborator

Nashtare commented Dec 7, 2023

We currently only have access in the logs to the proving trace upon failure.

It would be nice to also log

  • the GenerationInputs payload passed to generate_txn_proof() (to be able to regenerate locally easily when debugging)
  • the PublicValues associated to the AggregatableProof LHS and RHS arguments of generate_agg_proof(), and the ones for previous block proof and current one in generate_block_proof()
@vladimir-trifonov
Copy link
Contributor

@Nashtare
Copy link
Collaborator Author

Nashtare commented Apr 1, 2024

I may have badly phrased it when writing the issue, but rather than logging, I really meant writing to disk the related components. Logs are usually pretty noisy already, and with real states generating pretty large partial tries pre-txn, it's impossible to easily extract from log outputs stuff like generation inputs for instance.

Public Values on the other hand are always limited in size (though the vector of previous block hashes is on its own a bit large and noisy to print), but are sufficiently small to be only part of the logging output.

@vladimir-trifonov
Copy link
Contributor

@Nashtare #48

@vladimir-trifonov vladimir-trifonov moved this from Backlog to Ready To Merge in Zero EVM Apr 8, 2024
@Nashtare Nashtare linked a pull request Apr 24, 2024 that will close this issue
@github-project-automation github-project-automation bot moved this from Ready To Merge to Done in Zero EVM Apr 24, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

3 participants