This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
feat: provide IR for debugging upon failure #48
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vladimir-trifonov
requested review from
cpubot,
muursh and
Nashtare
as code owners
Nashtare
reviewed
Apr 4, 2024
There was a problem hiding this comment.
Thanks @vladimir-trifonov! Dropping a few inline comments, but overall looks good.
muursh
reviewed
Apr 10, 2024
muursh
reviewed
Apr 10, 2024
common/src/debug_utils.rs
Outdated
| fs::create_dir(DEBUG_FOLDER)?; | ||
| } | ||
|
|
||
| let mut file = File::create(input_file_path)?; |
There was a problem hiding this comment.
Do we want create over open if the file exists?
There was a problem hiding this comment.
yes, create opens the file if it exists
There was a problem hiding this comment.
Yeah that's not what I meant. They have different default behaviour
There was a problem hiding this comment.
do you mean we would like to append content instead of overwrite?
muursh
reviewed
Apr 10, 2024
muursh
reviewed
Apr 10, 2024
cpubot
suggested changes
Apr 16, 2024
cpubot
reviewed
Apr 17, 2024
cpubot
reviewed
Apr 17, 2024
cpubot
reviewed
Apr 17, 2024
vladimir-trifonov
force-pushed
the
ir_for_debugging
branch
from
5059c37
to
126c624
Compare
cpubot
reviewed
Apr 22, 2024
cpubot
reviewed
Apr 22, 2024
cpubot
suggested changes
Apr 23, 2024
cpubot
reviewed
Apr 24, 2024
0xaatif
pushed a commit
that referenced
this pull request
May 23, 2024
* feat: provide IR for debugging upon failure * fix: fix clippy issues * fix: fix pr comments * fix: make evm_arithmetization non optional for ops * fix: fix pr comments * fix: fix clippy issues * fix: fix clippy issue * fix: fix pr comment * fix: fix clippy issue * fix: fix cargo lock * fix: fix pr comments * fix: fix format issues * fix: fix save input on error for test-only * fix: fix pr comments * fix: fix * fix: fix clippy issue * fix: fmt fix --------- Co-authored-by: Vladimir Trifonov <trifonov.vp@gmail.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provide IR for debugging upon failure
Issue: #11