This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
feat: add transaction hash to zero trace #103
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanmarko
changed the title
feat: add transaction hash to zero trace
WIP: feat: add transaction hash to zero trace
Jun 9, 2024
atanmarko
force-pushed
the
feat/add-txn-hash
branch
from
June 10, 2024 10:16
f656bf6
to
a3e5fe1
Compare
atanmarko
changed the title
WIP: feat: add transaction hash to zero trace
feat: add transaction hash to zero trace
Jun 10, 2024
muursh
reviewed
Jun 10, 2024
muursh
approved these changes
Jun 10, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine to me. Is it tested?
@muursh Yes it is tested with the current Erigon feat/zero. Merging would also require update of zk_evm dependency to current develop branch, are there any obstacles for that? Latest |
@atanmarko |
atanmarko
force-pushed
the
feat/add-txn-hash
branch
from
June 10, 2024 16:07
20f78a7
to
1399d9e
Compare
muursh
reviewed
Jun 10, 2024
Nashtare
approved these changes
Jun 10, 2024
@atanmarko New versions have been published :) Feel free to swap to tag |
Retrieve block witness with a separate rpc call
atanmarko
force-pushed
the
feat/add-txn-hash
branch
from
June 12, 2024 21:16
6fce73c
to
fb417f3
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the Erigon commit output of
debug_traceBlockByNumber
has changed, so now tx result json looks like:Block witness returned from
eth_getWitness
now looks like:Deserialization logic in zero-bin has changed accordingly.
Trace decoder uses
primitive-types
H256 to represent hash, but as we are switching toAlloy
we chose herealloy::primitives::TxHash
for tx hash type.Resolves #97
Block witness is now retrieved with a separate
eth_getWitness
rpc call.