This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 11
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atanmarko
changed the title
WIP: feat: stdio parallel proving
feat: stdio parallel proving
Jun 13, 2024
atanmarko
force-pushed
the
feat/stdio-parallel-proving
branch
from
June 14, 2024 11:49
de27024
to
630e2f6
Compare
atanmarko
changed the base branch from
develop
to
fix/discard-intermediary-proofs
June 14, 2024 11:50
atanmarko
force-pushed
the
feat/stdio-parallel-proving
branch
from
June 14, 2024 12:04
630e2f6
to
e96fbdf
Compare
Nashtare
approved these changes
Jun 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall LGTM, just having one question regarding the use of Option
. Related to this point actually, I wonder if we don't want the stdio
mode to also have the keep_intermediate_proofs
argument, which currently is a jerigon
specific one.
Also minor nit, but I ran the [11231279981102658236,17674471959883319489,17252979625291653014,5508296138543908121]}]}]]},"steps":[]}],"final_poly":{"coeffs":[[8326671574015352282,18322989663851758183],[18444328255417511852,11587992679316513830],[13145008028612993865,17194453877708302593],[0,0]]},"pow_witness":1152921504338412293}},"public_inputs":[]}}]2024-06-14T16:37:46.645937Z INFO prover: Successfully generated witness for block 2.
2024-06-14T16:37:46.771867Z INFO prover: Successfully generated witness for block 3.
2024-06-14T16:37:46.891788Z INFO prover: Successfully generated witness for block 4.
2024-06-14T16:37:47.008929Z INFO prover: Successfully generated witness for block 5.
2024-06-14T16:37:47.119542Z INFO prover: Successfully generated witness for block 6.
2024-06-14T16:37:47.234381Z INFO prover: Successfully generated witness for block 7. We may want to have the print be done at the outer |
atanmarko
force-pushed
the
feat/stdio-parallel-proving
branch
from
June 14, 2024 17:41
7bffadb
to
ba9a855
Compare
Nashtare
reviewed
Jun 14, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolves #105
Resolves #107
Now the following can be done: