This repository has been archived by the owner on Jun 20, 2024. It is now read-only.
Implement RAII span for transaction timing to avoid cloning input #67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BGluth
approved these changes
Apr 23, 2024
Nashtare
approved these changes
Apr 23, 2024
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This removes the
run_and_wrap_txn_proof_in_elapsed_spanfunction in favor of an RAII guard. This is better aligned with the tracing span semantics, and most importantly, avoids cloning theGenerationInputs, which was required due to the input being moved into the closure argument ofrun_and_wrap_txn_proof_in_elapsed_span.