Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Charge call value gas prior to call #199

Merged
merged 2 commits into from
Apr 29, 2024

Conversation

frisitano
Copy link
Contributor

This PR modified the call gas logic to charge for call value gas prior to invoking the call. I have tested this on a prior failing block and it has solved the issue.

closes #194

@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Apr 28, 2024
Copy link
Collaborator

@Nashtare Nashtare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@frisitano
Copy link
Contributor Author

Please feel free to merge if all looks good. I don't have write access.

@Nashtare Nashtare merged commit c26bff4 into 0xPolygonZero:develop Apr 29, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

Kernel should not read target account of sys_call if gas is insufficient
4 participants