Fix KZG precompile I/O #213
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: evm_arithmetization
4l0n50
approved these changes
May 6, 2024
|
The issue with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some adaptation around KZG precompile CALLDATA / RETURNDATA format to pass transactions (couldn't test it previously as no tests on the Ethereum test suite side) and the hardcoded tests are only checking the parsing / pairing computation.
Note that txn 57 is still failing at the precompile level because of mismatch between
versioned_hashandcommitment hash. It's puzzling me a bit, because the official hardcoded tests that we run in the CI are passing fine, and skipping this validation check gets the rest of the precompile to run smoothly (so most importantly, the commitment is of correct form, i.e. compact G1 encoding and the KZG evaluation is verified). Keeping it for now while debugging the remaining errors, will go back to it later.