Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add blob gas fee burn for type-3 txns #219

Merged
merged 5 commits into from
May 3, 2024
Merged

Add blob gas fee burn for type-3 txns #219

merged 5 commits into from
May 3, 2024

Conversation

Nashtare
Copy link
Collaborator

@Nashtare Nashtare commented May 3, 2024

Also includes macro typo fix (%non_intrinsic_gas) and constant rename to match the name specified in EIP-4844 for consistency.

@Nashtare Nashtare added this to the Cancun - Q2 2024 milestone May 3, 2024
@Nashtare Nashtare self-assigned this May 3, 2024
@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label May 3, 2024
@Nashtare Nashtare requested review from 4l0n50 and LindaGuiga May 3, 2024 16:26
PUSH @GAS_PER_BLOB
%get_blob_versioned_hashes_list_length
MUL
PROVER_INPUT(blobbasefee)
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note: I'm reusing this here as we call PROVER_INPUT for the BLOBBASEFEE opcode, although we could implement it relatively cheaply in the KERNEL, if we were to want the switch.

Copy link
Contributor

@LindaGuiga LindaGuiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thank you!

@Nashtare Nashtare merged commit f225a5d into feat/cancun May 3, 2024
6 checks passed
@Nashtare Nashtare deleted the blob-gas branch May 3, 2024 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants