perf: Improve blake2 precompile #239
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: evm_arithmetization
Nashtare
commented
May 21, 2024
| @@ -1,14 +1,14 @@ | |||
| // 64-bit right rotation | |||
| %macro rotr_64(rot) | |||
There was a problem hiding this comment.
Identical modification to the one done for SHA2, except this one is a 64-bit rotation instead of 32.
hratoanina
approved these changes
May 23, 2024
evm_arithmetization/src/cpu/kernel/asm/hash/blake2/g_functions.asm
Outdated
Show resolved
Hide resolved
evm_arithmetization/src/cpu/kernel/asm/hash/blake2/g_functions.asm
Outdated
Show resolved
Hide resolved
evm_arithmetization/src/cpu/kernel/asm/hash/blake2/g_functions.asm
Outdated
Show resolved
Hide resolved
muursh
approved these changes
May 24, 2024
Nashtare
added a commit
that referenced
this pull request
May 27, 2024
* ci: add cargo audit job (#236) * fix: Revert interpreter stack display (#238) * Fix clippy doc_lazy_continuation (#247) * perf: Improve blake2 precompile (#239) * Speed-up some blake2 components * Some more optimizations * Cleanup * Endline * Some more speed-up * Fix comments * Clippy --------- Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improve some of the internal logic of
BLAKE2precompile.Yields around 19.1% savings.