Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(cancun): dummy payloads and public input retrieval #249

Merged
merged 5 commits into from
May 27, 2024
Merged

fix(cancun): dummy payloads and public input retrieval #249

merged 5 commits into from
May 27, 2024

Conversation

Nashtare
Copy link
Collaborator

Small fixes for cancun:

  • the decoder was only adding the beacon block roots contract to the state trie preimage for the first payload, which was causing a Kernel panic in case of empty blocks (the second dummy payload has txn_nb = 0 and would attempt to access it as well)
  • the second dummy payload for an empty block would have a txn counter set to 1 instead of 0
  • following blobbasefee removal from block metadata, the from_public_inputs method hadn't been updated accordingly.

@Nashtare Nashtare added the bug Something isn't working label May 25, 2024
@Nashtare Nashtare added this to the Cancun - Q2 2024 milestone May 25, 2024
@Nashtare Nashtare self-assigned this May 25, 2024
@github-actions github-actions bot added crate: trace_decoder Anything related to the trace_decoder crate. crate: evm_arithmetization Anything related to the evm_arithmetization crate. labels May 25, 2024
LindaGuiga
LindaGuiga approved these changes May 27, 2024
View reviewed changes
Copy link
Contributor

@LindaGuiga LindaGuiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thank you!

trace_decoder/src/decoding.rs Outdated Show resolved Hide resolved
@Nashtare @LindaGuiga
Update decoding.rs
d2d81b9 
Co-authored-by: Linda Guiga <101227802+LindaGuiga@users.noreply.github.com>
@Nashtare Nashtare enabled auto-merge (squash) May 27, 2024 09:21
@Nashtare Nashtare merged commit aea633c into feat/cancun May 27, 2024
6 checks passed
@Nashtare Nashtare deleted the fix/cancun_dummy_payloads branch May 27, 2024 09:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LindaGuiga LindaGuiga LindaGuiga approved these changes

@wborgeaud wborgeaud Awaiting requested review from wborgeaud

@muursh muursh Awaiting requested review from muursh

@cpubot cpubot Awaiting requested review from cpubot

Assignees

@Nashtare Nashtare

Labels
bug Something isn't working crate: evm_arithmetization Anything related to the evm_arithmetization crate. crate: trace_decoder Anything related to the trace_decoder crate.
Projects
Zero EVM
Status: Done
Milestone
Cancun - Q3 2024
Development

Successfully merging this pull request may close these issues.
2 participants
@Nashtare @LindaGuiga