fix(cancun): correct search loop in transient storage #257
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
crate: evm_arithmetization
4l0n50
approved these changes
Jun 3, 2024
| PUSH 1 | ||
| SUB // 1 - seg | ||
| ADD // new_len = (addr - seg) + 1 | ||
| // stack: pos, addr, original_value, slot, value, kexit_info |
There was a problem hiding this comment.
Just to see if I understood, this part of the code was not correct (because pos was not considered part of the stack) but it never got executed because pos'' > @GLOBAL_METADATA_TRANSIENT_STORAGE_LEN was always false?
There was a problem hiding this comment.
No the stack comment was wrong, but we were indeed using pos (as we should have) to update the length.
The stack before the conditional jump to this section is pos'' > len, pos'', addr, original_value, slot, value, kexit_info, effectively consuming the boolean on top and leaving pos'' as top of the stack.
There was a problem hiding this comment.
Yes, I meant that the top of the stack was pos'' and not addr.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The condition
If pos'' > @GLOBAL_METADATA_TRANSIENT_STORAGE_LEN we need to update the lengthwas always satisfied, because we were comparing the scaledposwith the unscaledlen.This PR also changes the length to be stored to be always scaled to reduce overhead in the loop, as well as fixes some stack comments / adds some more.