Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed leader crashing when .env not present #335

Merged
merged 2 commits into from
Jun 27, 2024

Conversation

BGluth
Copy link
Contributor

@BGluth BGluth commented Jun 26, 2024

Was crashing if attempting to run when the .env was not present, which is a situation that we probably should not be crashing in. This commit now treats any IO error as the file missing and in these cases continues to run the program.

Resolves #334.

- Was crashing if attempting to run when the `.env` was not present,
  which is a situation that we probably should not be crashing in. This
  commit now treats any IO error as the file missing and in these cases
  continues to run the program.
@BGluth BGluth requested a review from atanmarko June 26, 2024 18:11
@github-actions github-actions bot added the crate: zero_bin Anything related to the zero-bin subcrates. label Jun 26, 2024
@BGluth BGluth added this to the Cleanups and Misc. milestone Jun 26, 2024
zero_bin/leader/src/main.rs Outdated Show resolved Hide resolved
- Also made the error contain the internal error.
@BGluth BGluth enabled auto-merge (squash) June 26, 2024 18:23
@BGluth BGluth merged commit 9fd656e into develop Jun 27, 2024
11 checks passed
@BGluth BGluth deleted the fix/334_dotenvy_crashing_when_missing branch June 27, 2024 13:43
BGluth added a commit that referenced this pull request Jun 27, 2024
BGluth added a commit that referenced this pull request Jun 27, 2024
* Ran `cargo update`

* Ran `cargo upgrade --incompatible --recursive`

* `Cargo machete` pass

* Added in missed cleanup request from PR #335

* Requested PR changes for #341
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
crate: zero_bin Anything related to the zero-bin subcrates.
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

leader binary crashes if .env is missing
3 participants