Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(kernel): Check valid range for s and add test #363

Merged
merged 1 commit into from
Jul 5, 2024
Merged

fix(kernel): Check valid range for s and add test #363

merged 1 commit into from
Jul 5, 2024

Conversation

Nashtare
Copy link
Collaborator

@Nashtare Nashtare commented Jul 5, 2024

Address the issue on missing signature check.
Now decoding of s will check that s < N//2 + 1 as per EIP-2, i.e. s < ceil(N/2).

@Nashtare Nashtare added the bug Something isn't working label Jul 5, 2024
@github-actions github-actions bot added the crate: evm_arithmetization Anything related to the evm_arithmetization crate. label Jul 5, 2024
LindaGuiga
LindaGuiga approved these changes Jul 5, 2024
View reviewed changes
Copy link
Contributor

@LindaGuiga LindaGuiga left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@Nashtare Nashtare merged commit 043ab68 into develop Jul 5, 2024
14 checks passed
@Nashtare Nashtare deleted the fix/sig_s_range_check branch July 5, 2024 20:00
@Nashtare Nashtare added this to the Type 1 - Q3 2024 milestone Jul 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LindaGuiga LindaGuiga LindaGuiga approved these changes

@wborgeaud wborgeaud Awaiting requested review from wborgeaud wborgeaud is a code owner

@muursh muursh Awaiting requested review from muursh

Assignees
No one assigned
Labels
bug Something isn't working crate: evm_arithmetization Anything related to the evm_arithmetization crate.
Projects
Zero EVM
Status: Done
Milestone
Type 1 - Ethereum Mainnet
Development

Successfully merging this pull request may close these issues.
2 participants
@Nashtare @LindaGuiga