-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement Blob transactions (type-3) #50
Conversation
( | ||
GlobalMetadata::BlockBlobBaseFee, | ||
metadata.block_blob_base_fee, | ||
), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unrelated, but another tiny oversight of 0xPolygonZero/plonky2#1313
blob_gas_used and excess_blob_gas
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Partial review.
evm_arithmetization/src/cpu/kernel/asm/transactions/common_decoding.asm
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finishing my review.
I think some part of the block circuit logic is missing, namely the updating of the blob excess gas in connect_block_proof
.
Apart from that, looks good, thanks!
Do you mean the enforcement that the value is consistent with the parent block excess gas + blob_gas_used? I'm not sure this is really relevant, as we don't enforce anything on the blob gas market logic anyway (at least now). Or did you mean something else? |
@@ -281,6 +281,39 @@ global sys_basefee: | |||
SWAP1 | |||
EXIT_KERNEL | |||
|
|||
global sys_blobhash: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe you can add an interpreter test for this function?
I don't understand why would you need the evm tests for cancun for the type 3 parsing test. Is it for avoiding using py-evm? |
I meant to easily test. Ideally (probably not worth doing it on the current |
First part of dealing with #41
It doesn't deal with the actual blob gas market, this is low priority, though could be tackled in the future if judged necessary.
Once #46 is done, we could add a similar test than
evm_arithmetization/src/cpu/kernel/tests/transaction_parsing/parse_type_0_txn.rs
but for type-3 easily.