Bring latest main to feat/cancun
#61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Add missing docs * Minor * Apply suggestions from code review Co-authored-by: Ben <bmarsh94@gmail.com> * Apply suggestions from code review Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com> --------- Co-authored-by: Ben <bmarsh94@gmail.com> Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
- One test is a regression test. Next commit will fix bug.
- Should squash this though, as the regression test still fails.
- Note that this is different from `debug_query`. This logic is a lot more light-weight and meant for actual logic (instead of for debugging purposes).
- Also added missing tests for all `push_*` functions.
- The issue was `reset_tracked_trie_state` never traversing past the first node.
…e_fix Withdrawls not in state trie fix
* Code hash resolve fix + cleanup - Although we were adding any contract code created to the local code hash resolve table for the current txn, we were not adding this into the "global" lookup table. - Also cleaned up the logic for resolving code hashes. * Fix small typo Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com> * Requested PR changes for #44 --------- Co-authored-by: Ben <bmarsh94@gmail.com> Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
* fix: remove duplicate constraint * fix: add proper constraints for padding rows * fix: remove extra constraints * fix: simplify constraints using mul_sub gate * fix: move constraint outside loop * chore: rename * chore: add comment explaining constrain * fix: remove extra sub constraint
Nashtare's suggested changes for #39. Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com>
Additional tooling for allowing aggresive pruning logic
* Update README * Update sequence diagrams * Some minor tweaks * Add CHANGELOG * Update Cargo.toml with new plonky2-crates versions * Apply some comments
* Refactor access lists * Apply suggestions from code review Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com> * Update evm_arithmetization/src/cpu/kernel/asm/core/access_lists.asm Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Robin Salen <30937548+Nashtare@users.noreply.github.com> * Address reviews --------- Co-authored-by: Alonso González <alonso.gonzalez@toposware.com> Co-authored-by: Alonso González <alonso.gon@gmail.com>
Nashtare
added
the
crate: evm_arithmetization
muursh
approved these changes
Feb 26, 2024
BGluth
added a commit
that referenced
this pull request
Jun 17, 2024
Now logs time to generate proofs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pulls latest
mainchanges intofeat/cancunbranch. Necessary to have #59 easily reviewable, as it has been done on top of main and contains a lot of unrelated changes.