This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
feat: Add support for UniswapV2 and MultiBridge #250
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xianny
force-pushed
the
feat/uniswapv2
branch
4 times, most recently
from
2f1be8a to
0e60279
Compare
|
deploy staging |
|
deploy staging |
|
deploy staging |
* add MultiBridge support * bump asset-swapper version Co-authored-by: xianny <xianny@gmail.com>
|
We can observe a great impact (+23%) on realized price. 5% of swaps are >5bps better, 1% of swaps are > 10bps better.
A slight increase in revert rate (0s), though the 60-90s revert rate is improved (where we expect most fills to land). An increase in response time, though take it with a grain of salt as prod has more capacity to handle the load. Something to be cautious of though, perhaps we can retire some older Curves to make space. |
dekz
approved these changes
Jun 12, 2020
dekz
changed the title
|
deploy staging |
|
deploy production |
github-actions bot
pushed a commit
that referenced
this pull request
Jun 15, 2020
# [1.8.0](v1.7.0...v1.8.0) (2020-06-15) ### Bug Fixes * uniswap v2 buys ([#253](#253)) ([225db22](225db22)) ### Features * Add support for UniswapV2 and MultiBridge ([#250](#250)) ([29636e7](29636e7)), closes [#252](#252) * add transaction price information to meta-txn endpoints for UI ([#248](#248)) ([d26d6c6](d26d6c6))
|
🎉 This PR is included in version 1.8.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add support for UniswapV2
Using UniswapV2Router01 contract through asset-swapper.
Add
Uniswap_V2andUniswap_V2_ETHas new sources inexcludedSourcesparameter. No other changes.Testing Instructions
Unit tests should all still work.
Checklist
[WIP]if necessary.