This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
feat: Log QuoteReport to Kibana #298
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
steveklebanoff
commented
Jul 27, 2020
steveklebanoff
commented
Jul 27, 2020
steveklebanoff
changed the title
This reverts commit ddd8e9a.
|
deploy staging |
steveklebanoff
commented
Jul 28, 2020
steveklebanoff
commented
Jul 28, 2020
steveklebanoff
force-pushed
the
quote-report-reported
branch
from
737c712 to
f543b70
Compare
|
deploy staging |
alexkroeger
reviewed
Aug 5, 2020
| @@ -206,6 +216,11 @@ export class MetaTransactionService { | |||
| ) | |||
| .callAsync(); | |||
|
|
|||
| // log quote report and associate with txn hash if this is an RFQT firm quote | |||
There was a problem hiding this comment.
Does this mean we don't get a report if the meta TX didn't consider an RFQT quote?
There was a problem hiding this comment.
right now all meta-txn calls are RFQT enabled b/c they all come from matcha.
for non-meta-txn calls I do limit it only to RFQT firm quotes (
0x-api/src/handlers/swap_handlers.ts
Line 67 in ba495a7
if we find this data useful for firm quotes we can consider opening up to all requests (as long as get confirmation from Oskar that our log serve can handle it)
feuGeneA
suggested changes
Aug 6, 2020
|
deploy staging |
feuGeneA
approved these changes
Aug 6, 2020
|
deploy staging |
github-actions bot
pushed a commit
that referenced
this pull request
Aug 17, 2020
# [1.15.0](v1.14.0...v1.15.0) (2020-08-17) ### Bug Fixes * added new asset swapper ([#316](#316)) ([029a58a](029a58a)) * excluded sources test ([#322](#322)) ([1327261](1327261)) * lower db pool connections ([#318](#318)) ([d9cb04d](d9cb04d)) * lower db pool connections ([#319](#319)) ([bc9f218](bc9f218)) ### Features * Log QuoteReport to Kibana ([#298](#298)) ([7bd6d4d](7bd6d4d))
|
🎉 This PR is included in version 1.15.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs QuoteReports for RFQT firm quotes so that they can be consumed by Kibana and later put into metabase.
When a firm quote is to be submitted by the taker, it is logged with a
uniqueIdStringto be associated with the random number + timestamp when the fill occurs on chain (See #281)This does not work for meta txns, because the additional calldata is generated as the time that the meta txn service submits the fill on-chain, which is a different request than when the 'order salad' was created. In that case, we log the
zeroExTransactionHashso we can associate it in metabase.Also, we log the sources in "chunks", as outputting the entire object was too big to be parsed
TODO
apiKeycheck prior to logging back for meta_txnDescription
Testing Instructions
Checklist
[WIP]if necessary.