Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Show proper message when user rejects/cancel ETH wrapping #528

Merged

Conversation

unjapones
Copy link
Contributor

@unjapones unjapones commented Jun 4, 2019

Connects #503.

Includes

  • Show a proper message ('User denied transaction signature') when the user cancels/reject the wrap transaction in MetaMask. Previously, if the user rejected the transaction the message "You have ${currentEthAmount} ETH but you need ${ethNeeded} ETH to make this operation" would appear.
  • Move and rename some exception files that existed on the steps_modal folder.

My suggestion is to check the 1st commit for the 1st item above, and the last one for the files move and rename.

Screen

This is the screens of the corresponding message:

user_denied_transaction_signature

unjapones added 3 commits June 4, 2019 12:21
Add USER_DENIED_TRANSACTION_SIGNATURE_ERR to src/exceptions/common.
Update wrap_eth_step.tsx error handling to set/show different errorCaptions.
Rename unmounted_exception and made it more general.
@unjapones unjapones added the 0x feedback 0x team feedback label Jun 4, 2019
@unjapones unjapones requested a review from mariano-aguero June 4, 2019 15:52
@unjapones unjapones self-assigned this Jun 4, 2019
Change src/exceptions/common.tsx extension to .ts.
@unjapones unjapones requested a review from mariano-aguero June 6, 2019 13:55
@mariano-aguero mariano-aguero merged commit b7effd2 into development Jun 6, 2019
@mariano-aguero mariano-aguero deleted the fix-cancel-wrap-transaction-error-message branch June 6, 2019 14:02
birimbau pushed a commit to birimbau/VeriDex that referenced this pull request Jan 4, 2020
…action-error-message

Show proper message when user rejects/cancel ETH wrapping
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
0x feedback 0x team feedback
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants