This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Final changes to make all code follow our async conventions #312
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #96.
Depends on #307. After that PR is merged I'll change the base branch for this one to
development
.Summary of changes:
core.App.Start
blocking.core.App.Stop
.log.Panic
andlog.Fatal
whenever possible (there are some lingering cases where e.g., we pass a function into another function and don't have a good way to return errors).blockwatch.Watcher.Errors
channel. For non-critical errors, we log them inblockwatch.Watcher
directly. For critical errors, we return them inblockwatch.Watcher.Watch
. This makesblockwatch
more aligned with the rest of our async code.ctx.Done()
but sometimes with short timeouts or other signals).