This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
zeroex: Add order expiration buffer to zeroex.OrderValdiator #352
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albrow
changed the title
albrow
commented
Aug 12, 2019
| @@ -167,6 +167,10 @@ var ( | |||
| Code: "OrderHasInvalidSignature", | |||
| Message: "order signature must be valid", | |||
| } | |||
| ROMaxExpirationExceeded = RejectedOrderStatus{ | |||
There was a problem hiding this comment.
@fabioberger It doesn't exactly feel right to move ROMaxExpirationExceeded and MeshValidation into this package but I couldn't figure out another way to do it without introducing cyclical imports. We need to return something when signedOrder.ExpirationTimeSeconds is too big to fit in int64 and this existing order status fits pretty well. Any alternative ideas?
There was a problem hiding this comment.
Agreed. We could also create a dedicated package but this works for now.
fabioberger
approved these changes
Aug 12, 2019
| @@ -167,6 +167,10 @@ var ( | |||
| Code: "OrderHasInvalidSignature", | |||
| Message: "order signature must be valid", | |||
| } | |||
| ROMaxExpirationExceeded = RejectedOrderStatus{ | |||
There was a problem hiding this comment.
Agreed. We could also create a dedicated package but this works for now.
albrow
added a commit
that referenced
this pull request
Aug 14, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #341.
The problem was occurring because we did not respect the expiration buffer when validating incoming messages. This PR fixes the issue and also uses the same function
IsExpiredin both the expiration watcher and the order validator to avoid these kinds of issues in the future.