This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 111
Update all configuration options in preparation for browser support #366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albrow
changed the title
Create separate configuration options suitable for browser environments
Update all configuration options in preparation for browser support
Aug 16, 2019
albrow
commented
Aug 16, 2019
@@ -1,3 +1,5 @@ | |||
// +build !browser |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This build tag means the test won't run in browser environments. It wouldn't work because we try to load a JSON file.
fabioberger
approved these changes
Aug 20, 2019
albrow
force-pushed
the
feature/config-for-browsers
branch
from
August 20, 2019 18:18
7d14e8e
to
8b5a8df
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes a variety of configuration options throughout the code in preparation for full browser support. It also introduces a functioning MVP example of Mesh running in the browser in the examples/ directory and enables seamless headless browser tests in CircleCI and as part of
make test-all
. This allows us to remove the more manual qunit-based tests from themeshdb
package and just run all our tests normally.The in-browser example currently comes with the following caveats:
To run the browser example yourself, you need a web server that supports the Wasm MIME type. An easy option is to install
goexec
. Then run the following commands from the root of the repository:Finally visit http://localhost:8000 in your browser and open up the developer console to observe Mesh running 😄