This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
orderwatch: Check for stale removed orders more frequently
#471
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioberger
commented
Oct 24, 2019
albrow
suggested changes
Oct 24, 2019
albrow
approved these changes
Oct 24, 2019
There was a problem hiding this comment.
Just one small comment and other than that looks good to me!
albrow
reviewed
Oct 25, 2019
…marked for removal and should be permanently deleted
…te-change found when re-validating. Otherwise, a `removed` order can stick around forever if it's maker keeps transferring their excess balance for example
…rs to account for cases where order is flagged for removal due to UTC expiration and might still get filled/cancelled slightly after
…rom being cancelled immediately
fabioberger
force-pushed
the
feature/pruneRemovedMoreFrequently
branch
from
cf5ab8f
to
ac2ed19
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #459
This PR:
lastUpdatedTimewhen the entry is in-fact not updated (i.e., when we revalidate the order but no change to fillability was found). This could cause an order from a particularly active maker to stick around indefinitely despite being expired/cancelled/fullyFilled, because the changes in the maker's balance would cause this order to constantly be re-validated and it'slastUpdatedTimeto constantly get bumped up.