Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Implement order pinning #474

Merged
merged 13 commits into from
Oct 28, 2019
Merged

Implement order pinning #474

merged 13 commits into from
Oct 28, 2019

Conversation

albrow
Copy link
Contributor

@albrow albrow commented Oct 25, 2019

Fixes #469. The new feature is an optional parameter for RPC requests and the addOrdersAsync method in the TypeScript bindings, so this PR maintains backwards compatibility.

@albrow albrow changed the title Implement order pinning WIP: Implement order pinning Oct 25, 2019
@albrow albrow marked this pull request as ready for review October 25, 2019 21:10
@albrow albrow changed the title WIP: Implement order pinning Implement order pinning Oct 25, 2019
Copy link
Contributor

@fabioberger fabioberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is looking good! Can you also add support for the isPinned option to the TS client?

CHANGELOG.md Outdated Show resolved Hide resolved
core/core.go Outdated Show resolved Hide resolved
@albrow
Copy link
Contributor Author

albrow commented Oct 25, 2019

This is looking good! Can you also add support for the isPinned option to the TS client?

Nice catch! Just added.

Copy link
Contributor

@fabioberger fabioberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM once pinned count is added to stats response.

@albrow albrow merged commit 0b773a4 into development Oct 28, 2019
@albrow albrow deleted the feature/order-pinning branch October 28, 2019 17:38
@albrow albrow mentioned this pull request Oct 28, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants