This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Remove expiration buffer config and emit expiry events based on block timestamp #490
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioberger
force-pushed
the
refactor/removeBufferRenameExpiry
branch
from
5541352
to
783ac59
Compare
fabioberger
changed the title
albrow
suggested changes
Nov 5, 2019
core/core.go
Outdated
| ChainID: config.EthereumChainID, | ||
| MaxOrders: config.MaxOrdersInStorage, | ||
| MaxExpirationTime: metadata.MaxExpirationTime, | ||
| LatestBlockTimestamp: latestBlockTimestamp, |
There was a problem hiding this comment.
Does LatestBlockTimestamp really need to be passed in as part of Config on startup? It seems like:
- Unless there was a sudden unexpected shutdown, we will have already pruned any expired orders when the block watcher notified us of this block before Mesh was shutdown.
- The block watcher is going to notify us of the next latest block in a matter of seconds (or less) anyways.
There was a problem hiding this comment.
We could potentially miss a block re-org caused Unexpired event emission since on restart the OrderWatcher would not know what the latestBlockTimestamp was before the shutdown. It's an edge-case for sure, I just wanted to make sure the implementation was bullet proof. If you don't want to handle this edge-case, I can get rid of it.
…ric since it's used in multiple contexts
Co-Authored-By: Alex Browne <stephenalexbrowne@gmail.com>
…ect/0x-mesh into refactor/removeBufferRenameExpiry
…il to detect when it's not yet been set
…ion since the logic behaves correctly with it being set by the first event received
albrow
approved these changes
Nov 5, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed: #419 and #418
This PR:
UNEXPIREDorder event type.