This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Update go-libp2p-kad-dht to fix memory leak #539
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albrow
commented
Nov 18, 2019
| @@ -319,13 +319,6 @@ func (n *Node) ID() peer.ID { | |||
| // Start causes the Node to continuously send messages to and receive messages | |||
| // from its peers. It blocks until an error is encountered or `Stop` is called. | |||
| func (n *Node) Start() error { | |||
| // Note: dht.Bootstrap has a somewhat confusing name. It doesn't automatically | |||
There was a problem hiding this comment.
Calling Bootstrap is no longer necessary in the latest version of go-libp2p-kad-dht. See https://github.com/libp2p/go-libp2p-kad-dht/releases/tag/v0.3.0.
fabioberger
approved these changes
Nov 18, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a potential solution to #452. Memory snapshots revealed that
go.opencensus.io/tag.(*Map).insertwas responsible for an unusually large amount of memory (up to 100MB after a few days). That package is used bygithub.com/libp2p/go-libp2p-kad-dht. libp2p/go-libp2p-kad-dht#389 mentions this leak which was reported as fixed in version 0.2.1.This PR updates
github.com/libp2p/go-libp2p-kad-dhtto the latest version. We will need to continue to monitor memory usage to see if this fixes the problem.