This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is currently a discrepancy in the documentation regarding the default RPC port. See https://0x-org.gitbook.io/mesh/v/v6.0.1-beta/getting-started/deployment.
In part of the documentation we claim:
However, later the documentation conflicts with this when the
RPC_ADDR
environment variable itself is documented:In version
6.0.1-beta
, Mesh randomly selected an available port by default. So the second part of the docs was correct.After thinking about this some more, I actually think it makes more sense to use
60557
as the default port, as we already suggest in the docker-compose.yml file for enabling telemetry. This PR updates the defaultRPC_ADDR
to use port 60557 and also updates the relevant portions of our documentation so that everything is consistent.