Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

Set default RPC port to 60557 #542

Merged
merged 3 commits into from
Nov 19, 2019
Merged

Set default RPC port to 60557 #542

merged 3 commits into from
Nov 19, 2019

Conversation

albrow
Copy link
Contributor

@albrow albrow commented Nov 18, 2019

There is currently a discrepancy in the documentation regarding the default RPC port. See https://0x-org.gitbook.io/mesh/v/v6.0.1-beta/getting-started/deployment.

In part of the documentation we claim:

Ports 60557, 60558, and 60559 are the default ports used for the JSON RPC endpoint, communicating with peers over TCP, and communicating with peers over WebSockets, respectively.

However, later the documentation conflicts with this when the RPC_ADDR environment variable itself is documented:

// RPCAddr is the interface and port to use for the JSON-RPC API over
// WebSockets. By default, 0x Mesh will listen on localhost and will let the
// OS select a randomly available port.
RPCAddr string envvar:"RPC_ADDR" default:"localhost:0"

In version 6.0.1-beta, Mesh randomly selected an available port by default. So the second part of the docs was correct.

After thinking about this some more, I actually think it makes more sense to use 60557 as the default port, as we already suggest in the docker-compose.yml file for enabling telemetry. This PR updates the default RPC_ADDR to use port 60557 and also updates the relevant portions of our documentation so that everything is consistent.

@albrow albrow changed the title Set default RPC port to 60557. Set default RPC port to 60557 Nov 18, 2019
Copy link
Contributor

@fabioberger fabioberger left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a CHANGELOG entry for this.

@albrow albrow merged commit ac77927 into development Nov 19, 2019
@albrow albrow deleted the fix/default-rpc-port branch November 19, 2019 20:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants