This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Block as needed inside core.App until started #560
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Reminder to myself to add an entry to the CHANGELOG. |
fabioberger
approved these changes
Nov 27, 2019
albrow
changed the title
albrow
changed the title
This was referenced Nov 28, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #558.
As far as I can tell there is only one case where a field may not be fully initialized which can result in a nil pointer exception. All the issues we were seeing stem from this. The problem is that
app.nodeis nil beforeapp.Startis called (and sort of has to be because of how the libp2p works).This PR fixes the issue by using a
startedchannel inside ofcore.Appto signal whenapp.nodehas been initialized. Any methods that depend onapp.nodewill block by waiting to receive on theapp.startedchannel. This can be easily extended to support other edge cases for any fields cannot be initialized until afterStartis called.