This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
rpc,typescript: Add Paginated getOrders method #642
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fabioberger
commented
Jan 13, 2020
| @@ -173,7 +173,7 @@ blockchainTests.resets('WSClient', env => { | |||
| // timestamp is approximately equal (within 1 second) because the server | |||
| // will receive the request slightly after it is sent. | |||
| const now = new Date(Date.now()).getTime(); | |||
| const perPage = 10; | |||
| const perPage = ordersLength / 2; | |||
There was a problem hiding this comment.
This test wasn't actually making multiple paginated requests before so I modified it so that it does.
fabioberger
force-pushed
the
feature/paginatedGetOrdersMethod
branch
from
3afe790
to
83338c1
Compare
jalextowle
approved these changes
Jan 13, 2020
albrow
suggested changes
Jan 14, 2020
fabioberger
force-pushed
the
feature/paginatedGetOrdersMethod
branch
from
83338c1
to
ba0174b
Compare
…ed getOrders requests and add test
fabioberger
force-pushed
the
feature/paginatedGetOrdersMethod
branch
from
ba0174b
to
52de468
Compare
albrow
approved these changes
Jan 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #86