Skip to content
This repository has been archived by the owner on Oct 11, 2024. It is now read-only.

rpc: Add HTTP JSON-RPC Support #658

Merged
merged 9 commits into from
Feb 2, 2020
Merged

Conversation

fabioberger
Copy link
Contributor

Fixes: #122

Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a few nits

cmd/mesh/main.go Show resolved Hide resolved
cmd/mesh/rpc_handler.go Outdated Show resolved Hide resolved
Copy link
Contributor

@albrow albrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabioberger can we add some tests for the new HTTP API?

examples/go/add-order/main.go Outdated Show resolved Hide resolved
examples/go/README.md Outdated Show resolved Hide resolved
## v8.1.2

### Bug fixes 🐞

- Update DevUtils contract addresses to version that fixes issues for Augur. ([#662](https://github.com/0xProject/0x-mesh/pull/662)).
- Update DevUtils contract to version that removed maker transfer simulation. ([#662](https://github.com/0xProject/0x-mesh/pull/662)).
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should have been changed in @jalextowle PR but since it was missed, I'll update it now.

Copy link
Contributor

@albrow albrow left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fabioberger did you see my comment here: #658 (review)?

CHANGELOG.md Outdated Show resolved Hide resolved
@fabioberger
Copy link
Contributor Author

@albrow added HTTP rpc integration tests.

Copy link
Contributor

@jalextowle jalextowle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

After fixing the nit, this looks gtg

rpc/server.go Outdated Show resolved Hide resolved
@fabioberger fabioberger merged commit ba639fe into development Feb 2, 2020
@fabioberger fabioberger deleted the Add-HTTP-JSON-RPC-support branch February 2, 2020 09:33
@xianny
Copy link
Contributor

xianny commented Feb 21, 2020

hey @fabioberger just noticed this needs to be updated to say we support HTTP too:
https://github.com/0xProject/0x-mesh/blob/master/docs/rpc_api.md#similarities-to-the-ethereum-json-rpc-api

Not sure if you'd want to add any other notes so I am not opening a PR myself.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants