-
Notifications
You must be signed in to change notification settings - Fork 111
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a few nits
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabioberger can we add some tests for the new HTTP API?
e86bf17
to
20a9ab7
Compare
## v8.1.2 | ||
|
||
### Bug fixes 🐞 | ||
|
||
- Update DevUtils contract addresses to version that fixes issues for Augur. ([#662](https://github.com/0xProject/0x-mesh/pull/662)). | ||
- Update DevUtils contract to version that removed maker transfer simulation. ([#662](https://github.com/0xProject/0x-mesh/pull/662)). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should have been changed in @jalextowle PR but since it was missed, I'll update it now.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@fabioberger did you see my comment here: #658 (review)?
8b82797
to
67c1489
Compare
@albrow added HTTP rpc integration tests. |
0a81981
to
6e7146d
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
After fixing the nit, this looks gtg
hey @fabioberger just noticed this needs to be updated to say we support HTTP too: Not sure if you'd want to add any other notes so I am not opening a PR myself. |
Fixes: #122