This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Addressed inconsistencies in the Typescript bindings in the browser #697
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…geCancelUpToEvent` ts binding
jalextowle
changed the title
albrow
reviewed
Feb 3, 2020
| ordersInfos: WrapperOrderInfo[]; | ||
| } | ||
|
|
||
| export interface GetOrdersResponse { | ||
| snapshotID: string; | ||
| snapshotTimestamp: number; | ||
| snapshotTimestamp: Date; |
There was a problem hiding this comment.
This is technically a breaking change. I'm okay with merging for now but let's update the changelog later before we release 9.0.0.
There was a problem hiding this comment.
0xee3512fbf0f301e14015c8f91ac02beeba256bfd0857457b7a05c2e41d089522
albrow
reviewed
Feb 3, 2020
| @@ -480,13 +486,13 @@ export interface ExchangeCancelEvent { | |||
|
|
|||
| export interface ExchangeCancelUpToEvent { | |||
| makerAddress: string; | |||
| senderAddress: string; | |||
| orderSenderAddress: string; | |||
There was a problem hiding this comment.
This is a breaking change also.
albrow
approved these changes
Feb 3, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashes some bugs in the browser Typescript bindings and in the Go to Javascript conversion functions.