This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Use our fork of pubsub which increases queue size #732
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
albrow
added
bug
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Possible fix for #551. This PR updates Mesh to use a custom fork of
libp2p/go-libp2p-pubsub, which increases the size of the channel for incoming messages from 32 to 1000. This fixes an issue reported by Augur where orders were sometimes not being received by peers in stress testing/benchmarking scenarios. The same issue could also be encountered in the real world, although it is less likely since #692.See also libp2p/go-libp2p-pubsub#217 which mentions the small queue sizes and other related issues.