This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Release version 9.3.0 #789
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…up (#764) * Periodically rerun ordersync instead of running it only once on startup * Add a random jitter to ordersync delay * Change ordersyncApproxDelay to 1 hour * Add log message when starting ordersync service * Improve comment clarity
* Update Ganache DevUtils address * Update Ganache snapshot version * Update Dummy ERC1155 contract address
* Add a polyfill for WebAssembly.instantateStreaming * Fix linter error * Update changelog
* ADDS check that configured chain id matches RPC WIP * FIXES async error channel race condition and clean up code * FIXES remove unnecessary wait group, move chain id fetch into helper * FIXES use ParseBig256 for parsing chain id response from eth_chainId * Fix race condition in core.App.Start * Update changelog Co-authored-by: Alex Browne <stephenalexbrowne@gmail.com>
* Add custom order filters docs * Fix nits * Add doc to menu * Improve limitations description * Add example filters * Merge the two example sections
* Fix small bug in expirationwatcher * Add a test to ensure that a "barely expired" order will be pruned * Update CHANGELOG with PR number
* WIP Improve scenario package * Create orderopts package. Update scenario and ordervalidator to use it * Fix remaining ordervalidator tests * Update most orderwatcher tests * Support setting taker state and enable remaining orderwatcher tests * Fix remaining tests (only MultiAsset disabled) * Uncomment test that depends on on-chain state for a StaticCall order * Fix browser integration test * Remove unneeded ethClient parameter in a few places * Move sleep statement in order_watcher_test.go * Address Alex Towle's feedback * Remove old comment
* scenario: Add ability to create multiple orders in a single batch * Fix some typos
* Add missing regression test for ordersync pagination subprotocol Also fixes a minor bug where the exponential backoff for ordersync was too long in some circumstances. * Remove some duplicated code in core_test.go
jalextowle
approved these changes
Apr 16, 2020
| @@ -58,7 +58,7 @@ var GanacheAccountToPrivateKey = map[common.Address][]byte{ | |||
| var GanacheDummyERC721TokenAddress = common.HexToAddress("0x07f96aa816c1f244cbc6ef114bb2b023ba54a2eb") | |||
|
|
|||
| // GanacheDummyERC1155MintableAddress is the dummy ERC1155 token address in the Ganache snapshot | |||
| var GanacheDummyERC1155MintableAddress = common.HexToAddress("0x8d42e38980ce74736c21c059b2240df09958d3c8") | |||
| var GanacheDummyERC1155MintableAddress = common.HexToAddress("0x038f9b392fb9a9676dbaddf78ea5fdbf6c7d9710") | |||
There was a problem hiding this comment.
Was this wrong before? I wasn't aware that we changed it's location in the migration script.
There was a problem hiding this comment.
It did change with the updated snapshot we're now using (6.2.4). Prior to this version, we were on version 5.1.0. It must have changed sometime between those two versions.
|
|
||
| Loads the Wasm module that is provided by a response. | ||
|
|
||
| **Parameters:** | ||
|
|
||
| Name | Type | Description | | ||
| ------ | ------ | ------ | | ||
| `response` | `Response or Promise<Response>` | The Wasm response that supplies the Wasm binary | | ||
| `response` | `Response | Promise<Response>` | The Wasm response that supplies the Wasm binary | |
There was a problem hiding this comment.
🤞 that this renders correctly.
fabioberger
approved these changes
Apr 17, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.