This repository has been archived by the owner on Oct 11, 2024. It is now read-only.
Autogen Bug Fixes to Rust Code #706
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 10 commits
April 8, 2020 12:14
aleph-v
changed the title
z2trillion
reviewed
Jun 8, 2020
| let path = Path::new(&name); | ||
| let display = path.display(); | ||
| let mut file = match File::create(&path) { | ||
| Err(why) => panic!("couldn't create {}: {}", display, why.to_string()), | ||
| Ok(file) => file, | ||
| }; | ||
|
|
||
| println!("{}: {:?}", index, periodic); | ||
| // println!("{}: {:?}", index, periodic); |
There was a problem hiding this comment.
Can you just remove this?
| ) -> Result<(), std::io::Error> { | ||
| let name = format!("contracts/{}.sol", name); | ||
| let name = format!("{}/{}.sol", output_directory, name); |
There was a problem hiding this comment.
Can you add a TODO to use this https://doc.rust-lang.org/std/path/struct.Path.html?
z2trillion
approved these changes
Jun 8, 2020
added 2 commits
June 8, 2020 17:10
This was referenced Jun 8, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
wipwhile in development.bug,enhancement.Changelog.md.Semver: https://github.com/rust-lang/rfcs/blob/master/text/1105-api-evolution.md
https://semver.org/