Add support for nested user-defined struct types #55
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
moodlezoup
force-pushed
the
feat/abi-encoder-nested-structs
branch
from
374953e to
1ba95ee
Compare
moodlezoup
commented
Jan 15, 2022
Comment on lines
+62
to
+63
| // https://github.com/0xProject/0x-monorepo/issues/2000 | ||
| describe.skip('with an existing output file', () => { |
There was a problem hiding this comment.
not sure why these started failing on CI
moodlezoup
force-pushed
the
feat/abi-encoder-nested-structs
branch
from
b190eb2 to
8317345
Compare
moodlezoup
force-pushed
the
feat/abi-encoder-nested-structs
branch
from
068bd55 to
a961463
Compare
dorothy-zbornak
approved these changes
Jan 19, 2022
| @@ -15,7 +15,7 @@ | |||
| "build:ci": "yarn build", | |||
| "test": "run-p run_mocha && yarn test_cli", | |||
| "test:circleci": "yarn test:coverage && yarn test_cli", | |||
| "run_mocha": "(uname -s | grep -q Darwin && echo 'HACK! skipping mocha run due to https://github.com/0xProject/tools/issues/2000') || mocha --require source-map-support/register --require make-promises-safe lib/test/*_test.js --timeout 100000 --bail --exit", | |||
Fix detection for `provider.send(payload,cb)` to use replaceAll inste…
moodlezoup
force-pushed
the
feat/abi-encoder-nested-structs
branch
from
64f10ba to
5a12743
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds an optional parameter to
AbiEncoder.createso that you can pass in user-defined types referenced by the primary typeTesting instructions
Types of changes
Checklist:
[WIP]if necessary.