Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor of state committing #492

Merged
merged 4 commits into from
Jun 13, 2024
Merged

Refactor of state committing #492

merged 4 commits into from
Jun 13, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Jun 12, 2024

Usage related changes

  • None

Development related changes

  • Titular refactor:
    • Remove redundant CommittedClassStorage::insert_and_commit
    • Call commit_with_diff directly on Starknet instead of on pending_state
      • Reduce visibility of StarknetState::commit_with_diff to pub crate
    • Rename generate_new_block to generate_new_block_and_state to better reflect its functionality
    • Created while implementing the proposal in Memory exhaustion  #272 (comment)
    • Not enough improvement to c l o s e issue: Refactor state #484

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@FabijanC FabijanC requested a review from mikiw June 13, 2024 06:46
@FabijanC FabijanC marked this pull request as ready for review June 13, 2024 06:46
@FabijanC FabijanC merged commit 867f447 into main Jun 13, 2024
@FabijanC FabijanC deleted the refactor-state-commit branch June 13, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants