Merge main into json-rpc-v0.8.0 #632
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* remove handle_transaction_result, refactor errors * integration tests * added new error type * typo * fixed unit tests * fixed integration test * remove fully qualified names in errors file * changed test name * reuse variable * replace declare_deploy_v1 with declare_v3_deploy_v3 * add simulate transaction validation check * add functionality * refactor if else with match * remove trait implementation * changed error variant * commment
FabijanC
requested changes
Oct 24, 2024
There was a problem hiding this comment.
- I checked
test_estimate_fee.rsandtest_simulate_transactions.rsfor duplicate tests and found one (left a comment), but it would be good if you also looked at those and other files you consider worthy. - Are we sure that this eliminates conflicts in future merges of
mainandjson-rpc-v0.8.0?
FabijanC
approved these changes
Oct 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Usage related changes
Development related changes
Checklist:
./scripts/format.sh./scripts/clippy_check.sh./scripts/check_unused_deps.sh./scripts/check_spelling.sh./website/README.md