Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support subscribing to transaction status via ws #646

Merged
merged 71 commits into from
Nov 15, 2024
Merged

Support subscribing to transaction status via ws #646

merged 71 commits into from
Nov 15, 2024

Conversation

FabijanC
Copy link
Contributor

@FabijanC FabijanC commented Nov 13, 2024 •
edited
Loading

Usage related changes

Development related changes

  • Move existing subscription testing helper functions to common utils.
  • Make TransactionStatus::execution_status optional according to the spec.
  • Remove Notification suffix from SubscriptionNotification enum variant names.

Checklist:

  • Checked out the contribution guidelines
  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/clippy_check.sh
  • No unused dependencies - ./scripts/check_unused_deps.sh
  • No spelling errors - ./scripts/check_spelling.sh
  • Performed code self-review
  • Rebased to the latest commit of the target branch (or merged it into my branch)
    • Once you make the PR reviewable, please avoid force-pushing
  • Updated the docs if needed - ./website/README.md
  • Linked the issues resolvable by this PR - linking info
  • Updated the tests if needed; all passing - execution info

@FabijanC
Improve readability in json_rpc/mod.rs
6fdf0d8
@FabijanC
Add communication via channel [skip ci] [TODO]
062c55b
@FabijanC
Use tokyo::sync::mpsc; edit TODOs
6942603
@FabijanC
Improve websocket/subscription types [skip ci]
499151e
@FabijanC
Add broadcast_changes skeleton [skip ci]
960f6cb
@FabijanC
Enable NewHeads subscription - many TODOs [skip ci]
f7f248c
@FabijanC
Merge branch 'json-rpc-v0.8.0' into ws-methods [skip ci]
0503916
@FabijanC
Restructure SubscriptionResponse [skip ci]
cb8a99f
@FabijanC
Merge branch 'json-rpc-v0.8.0' into ws-methods [skip ci]
3a719af
@FabijanC
Introduce ID (rpc and subscription) param [skip ci]
b5b2272
@FabijanC
Return confirmation on subscribe request [skip ci]
73120bd
@FabijanC
Add subscribe and notify methods to SocketContext [skip ci]
4bb5ef8
@FabijanC
Remove mpsc channel; use ws writer directly [skip ci]
9a4a6fa
@FabijanC
Remove unwraps in subscribe.rs [skip ci]
c638e3f
@FabijanC
Ignore general websocket RPC tests; introduce subscription test file …
beacd6a 
…[skip ci]
@FabijanC
Merge branch 'json-rpc-v0.8.0' into ws-methods [skip ci]
62952b7
@FabijanC
Fix serialization; add block subscription happy path test [skip ci]
d973f1e
@FabijanC
Add helper for receiving rpc via ws [skip ci]
a5bc0b3
@FabijanC
Add unhappy path test [skip ci]
fc94d3f
@FabijanC
Add multiple subscribers test [skip ci]
3382a30
@FabijanC
Test subscribing to old block [skip ci]
225a601
@FabijanC
Rename to test_subscription_to_blocks.rs [skip ci]
72ea6d2
@FabijanC
Start starknet_unsubscribe [skip ci]
cc05e4f
@FabijanC
Implement unsubscription TODOs [skip ci]
77eff45
@FabijanC
Add unsubscription tests [skip ci]
65307e5
@FabijanC
Replace panic! with todo! [skip ci]
e89dae2
@FabijanC
Refactor ws error sending [skip ci]
d0bf128
@FabijanC
Improve on_websocket_call [skip ci]
5fb0511
@FabijanC
Expand testing to pending and block hash [skip ci]
8821f68
@FabijanC
Refactor broadcast_changes
d76675b
@FabijanC
Merge branch 'ws-methods' into ws-methods-tx
5fa5006
@FabijanC
Edit TODO comments [skip ci]
ed32a36
@FabijanC
Merge branch 'json-rpc-v0.8.0' into ws-methods-tx
1ed8a4f 
* [skip ci]
@FabijanC
Merge branch 'json-rpc-v0.8.0' into ws-methods-tx
48d527b 
* [skip ci]
@FabijanC
Fix block id input; fix subscribe; improve tx subscription impl [skip…
3e3291c 
… ci]
@FabijanC
Merge branch 'json-rpc-v0.8.0' into ws-methods-tx
0da501a
@FabijanC
Add tx status subscription logic [skip ci] (pending testing)
08f3880
@FabijanC
Simplify SubscriptionNotification enum variant names
c5824cb
@FabijanC
Replace match with if and return error in tx status subscription
c165afb
@FabijanC
Fix test: subscribe_to_new_tx_status_happy_path
cef0ec6
@FabijanC
Add extensive tx status subscription testing
88ade87
@FabijanC
Fix impossible case matching
03843de
@FabijanC
Add TODOs related to pending block diff [skip ci]
4b4f087
@FabijanC
Merge branch 'json-rpc-v0.8.0' into ws-methods-tx
e11ea57
@FabijanC
Fix block and tx hash in subscription; all tests passing
823778b
@FabijanC
Refactor subscription matching; remove unused struct and derive
b3e50ce
@FabijanC
Minor refactor
1b45ead
@FabijanC
Refactor subscription tag extraction
1657939
@FabijanC
Improve clarity of change broadcasting
9d2572e
@FabijanC
Rework tests after review
2fb8b45
@FabijanC
Latest tx should not be notified of with pending subscription
5f131bc
@FabijanC FabijanC marked this pull request as ready for review November 15, 2024 13:40
@FabijanC FabijanC merged commit a598805 into json-rpc-v0.8.0 Nov 15, 2024
@FabijanC FabijanC deleted the ws-methods-tx branch November 15, 2024 15:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marioiordanov marioiordanov marioiordanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabijanC @marioiordanov