Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

In blocks-on-demand mode, all transactions have transaction_index 0 #514

Closed
FabijanC opened this issue Jun 30, 2023 · 0 comments · Fixed by #512
Closed

In blocks-on-demand mode, all transactions have transaction_index 0 #514

FabijanC opened this issue Jun 30, 2023 · 0 comments · Fixed by #512
Labels
Context: coupled interact with some parts of the codebase Difficulty: easy anybody can understand it Duration: under a day will take up to one day Techno: python Python Type: bug Something isn't working

Comments

@FabijanC
Copy link
Collaborator

FabijanC commented Jun 30, 2023 •
edited
Loading

They shouldn't. First transaction in a block should have index, second should have index 1, etc.

Reproduce by:

  1. starknet-devnet --blocks-on-demand
  2. Send a couple of transactions
  3. Retrieve the pending block
    • curl localhost:5050/feeder_gateway/get_block?blockNumber=pending (your URL may vary)
@FabijanC FabijanC added Type: bug Something isn't working Techno: python Python Context: coupled interact with some parts of the codebase Difficulty: easy anybody can understand it Duration: under a day will take up to one day OnlyDust Open for OnlyDust contributors labels Jun 30, 2023
@FabijanC FabijanC mentioned this issue Jun 30, 2023
Merged
8 tasks
@FabijanC FabijanC removed the OnlyDust Open for OnlyDust contributors label Jun 30, 2023
@github-project-automation github-project-automation bot moved this from 🆕 New to ✅ Done in starknet-devnet Jul 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
Context: coupled interact with some parts of the codebase Difficulty: easy anybody can understand it Duration: under a day will take up to one day Techno: python Python Type: bug Something isn't working
Projects
No open projects
starknet-devnet
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adapt to Starknet / cairo-lang 0.12.0a0 0xSpaceShard/starknet-devnet
1 participant
@FabijanC