Skip to content
This repository has been archived by the owner on Dec 15, 2023. It is now read-only.

Adapt to Starknet / cairo-lang 0.12.0a0 #512

Merged
merged 12 commits into from
Jul 3, 2023
Merged

Adapt to Starknet / cairo-lang 0.12.0a0 #512

merged 12 commits into from
Jul 3, 2023

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Jun 28, 2023 •
edited
Loading

Usage related changes

Development related changes

  • Rewrite testing contracts to cairo 2
  • Stop generating ABI for Cairo 1 contracts in tests - not needed for interaction
  • According to cairo-lang requirements, add StorageDomain to nonce and storage manipulation (some state methods now require the new storage_domain param)
  • Forking tests are not passing - expected because testnet (used in forking tests) hasn't been updated (only integration has been updated)

Checklist:

  • Applied formatting - ./scripts/format.sh
  • No linter errors - ./scripts/lint.sh
  • Performed code self-review
  • Rebased to the last commit of the target branch (or merged it into my branch)
  • Documented the changes
  • Linked the issues which this PR resolves
  • Updated the tests
  • All tests are passing - ./scripts/test.sh

@FabijanC FabijanC marked this pull request as draft June 28, 2023 15:52
@FabijanC
Install cairo-lang@0.11.2 [skip ci]
8fceccc
@FabijanC
Replace PENDING tx status with ACCEPTED_ON_L2
6a4a592 
* [skip ci]
@FabijanC
Use StorageDomain in get_nonce_at and get_storage_at
7bd2125 
* [skip ci]
@FabijanC
Partial adaptation
02f003c 
* Remove ABI of cairo 1

* Add missing StorageDomain

* Modify default compiler args

* [skip ci]
@FabijanC FabijanC changed the title Adapt 0.12.0 Adapt to Starknet / cairo-lang 0.12.0 Jun 30, 2023
@FabijanC FabijanC marked this pull request as ready for review July 3, 2023 09:34
mikiw
mikiw approved these changes Jul 3, 2023
View reviewed changes
Copy link
Contributor

@mikiw mikiw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

besides my questions/concerns PR looks fine

starknet_devnet/account_util.py Show resolved Hide resolved
starknet_devnet/fee_token.py Show resolved Hide resolved
@FabijanC FabijanC merged commit dc46112 into master Jul 3, 2023
@FabijanC FabijanC deleted the adapt-0.12.0 branch July 3, 2023 11:20
@FabijanC FabijanC changed the title Adapt to Starknet / cairo-lang 0.12.0 Adapt to Starknet / cairo-lang 0.12.0a0 Jul 3, 2023
@FabijanC FabijanC mentioned this pull request Jul 4, 2023
Merged
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@mikiw mikiw mikiw approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

In blocks-on-demand mode, all transactions have transaction_index 0 Support Starknet / cairo-lang 0.12
2 participants
@FabijanC @mikiw