Adapt Account to OpenZeppelin 0.1.0 and Argent 0.2.1 #108
Conversation
FabijanC
changed the title
src/account-utils.ts
Outdated
| // Full path to where the artifacts will be saved | ||
| const artifactsTargetPath = path.join( | ||
| baseArtifactsPath, | ||
| ACCOUNT_ARTIFACTS_VERSION, | ||
| accountType, | ||
| artifactsVersion, | ||
| artifactsBase | ||
| ); | ||
|
|
||
| const jsonArtifact = artifactsName + ".json"; | ||
| const abiArtifact = artifactsName + ABI_SUFFIX; | ||
|
|
||
| const artifactLocationUrl = GITHUB_ACCOUNT_ARTIFACTS_URL.concat( |
There was a problem hiding this comment.
Why are we using Github repo for this? Why don't we just load the artifacts from the directory?
| const { nonce } = await this.starknetContract.call("get_nonce"); | ||
| return nonce; | ||
| } | ||
|
|
||
| protected hasRawOutput(): boolean { |
There was a problem hiding this comment.
Why is this a function?
There was a problem hiding this comment.
If you're asking why it isn't a property, it doesn't have to be, it's just following the same paradigm as getExecutionFunctionName, which could also be a property set through constructor.
| }); | ||
| }); | ||
| } | ||
| const baseArtifactsPath = path.join(hre.config.paths.starknetArtifacts, ACCOUNT_ARTIFACTS_DIR); | ||
|
|
||
| // Full path to where the artifacts will be saved | ||
| const artifactsTargetPath = path.join( |
There was a problem hiding this comment.
Why are artifacs being saved to a target directory?
There was a problem hiding this comment.
Accounts are also contracts. So for the plugin to be able to interact with them as contracts, their artifacts need to be in the artifacts directory. Internally, doing account.call(...) does something like account.starknetContract.call(...)
Usage related changes
Development related changes
__execute__Checklist:
pluginbranch ofstarknet-hardhat-example.