Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use sleep-check loop on integrated-devnet startup #126

Merged
merged 1 commit into from
Jun 22, 2022
Merged

Use sleep-check loop on integrated-devnet startup #126

merged 1 commit into from
Jun 22, 2022

Conversation

FabijanC
Copy link
Collaborator

@FabijanC FabijanC commented Jun 22, 2022 •
edited
Loading

Usage related changes

  • Prevent connection errors from happening on integrated-devnet startup (if sleeping for a too short period of time)

Development related changes

None

Checklist:

  • I have formatted the code
  • I have performed a self-review of the code
  • I have rebased to the base branch
  • I have documented the changes
  • I have updated the tests
  • I have created a PR to the plugin branch of starknet-hardhat-example.

@FabijanC FabijanC requested a review from qperrot June 22, 2022 11:59
qperrot
qperrot approved these changes Jun 22, 2022
View reviewed changes
Copy link
Contributor

@qperrot qperrot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything seems ok

@FabijanC FabijanC merged commit 89cbb17 into master Jun 22, 2022
@FabijanC FabijanC deleted the devnet-sleep-loop branch June 22, 2022 12:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qperrot qperrot qperrot approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@FabijanC @qperrot